Skip to content

[release/13.5] Fix DevTunnel health check for auto-selected regions - #19853

Merged
Damian Edwards (DamianEdwards) merged 3 commits into
release/13.5from
backport/pr-19230-to-release/13.5
Sep 2, 2026
Merged

[release/13.5] Fix DevTunnel health check for auto-selected regions#19853
Damian Edwards (DamianEdwards) merged 3 commits into
release/13.5from
backport/pr-19230-to-release/13.5

Conversation

@aspire-repo-bot

@aspire-repo-bot aspire-repo-bot Bot commented Sep 2, 2026 •
edited by DamianEdwards
Loading

Copy link
Copy Markdown
Contributor

Backport of #19230 to release/13.5

/cc Damian Edwards (@DamianEdwards) Vladyslav Danilchuk (@Vladipz)

Customer Impact

Customers using dev tunnels see errors currently.

Testing

New tests added to cover scenario and agent-led functional testing confirms fix.

Risk

Low.

Regression?

Yes, regressed in 13.3

Copilot AI balanced review requested due to automatic review settings September 2, 2026 00:44
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19853

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19853"

@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Sep 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
Copilot AI reviewed Sep 2, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused fix consistently propagates qualified IDs and includes coverage for startup and health-check paths.

Pull request overview

Backports the DevTunnel region-resolution fix so port and access operations use cluster-qualified tunnel IDs.

Changes:

  • Uses IDs returned by tunnel create/show operations.
  • Adds regression coverage for auto-selected regions.
  • Extends the test client to simulate qualified IDs.
File summaries
File Description
src/Aspire.Hosting.DevTunnels/DevTunnelHealthCheck.cs Uses the resolved ID for access checks.
src/Aspire.Hosting.DevTunnels/DevTunnelResourceBuilderExtensions.cs Uses the created tunnel ID for port operations.
tests/Aspire.Hosting.DevTunnels.Tests/DevTunnelResourceBuilderExtensionsTests.cs Adds auto-region regression tests.
tests/Aspire.Hosting.DevTunnels.Tests/TestDevTunnelClient.cs Supports configured created tunnel IDs.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@DamianEdwards
Damian Edwards (DamianEdwards) changed the base branch from release/13.5 to DamianEdwards/bump-release-13-5-4 September 2, 2026 18:40
Base automatically changed from DamianEdwards/bump-release-13-5-4 to release/13.5 September 2, 2026 19:16
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Tests selector (audit mode)

The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement.

8 / 100 test projects · 2 jobs, from 4 changed files.

Selected test projects (8 / 100)

Aspire.Hosting.Azure.Kubernetes.Tests, Aspire.Hosting.Azure.Tests, Aspire.Hosting.Blazor.Tests, Aspire.Hosting.DevTunnels.Tests, Aspire.Hosting.Dotnet.Tests, Aspire.Hosting.Maui.Tests, Aspire.Hosting.Radius.Tests, Aspire.Hosting.Tests

Selected jobs (2)

extension-e2e, typescript-api-compat

How these were chosen — grouped by what changed

🔧 src/Aspire.Hosting.DevTunnels/DevTunnelHealthCheck.cs (changed source)
→ 1 directly: Aspire.Hosting.DevTunnels.Tests
→ 7 via the project graph: Aspire.Hosting.Azure.Kubernetes.Tests (3 hops), Aspire.Hosting.Azure.Tests (2 hops), Aspire.Hosting.Blazor.Tests (2 hops), Aspire.Hosting.Dotnet.Tests (2 hops), Aspire.Hosting.Maui.Tests (2 hops), Aspire.Hosting.Radius.Tests (2 hops), Aspire.Hosting.Tests

🔧 src/Aspire.Hosting.DevTunnels/DevTunnelResourceBuilderExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.DevTunnels.Tests

🧪 tests/Aspire.Hosting.DevTunnels.Tests/DevTunnelResourceBuilderExtensionsTests.cs (changed test)
→ 1 directly: Aspire.Hosting.DevTunnels.Tests

🧪 tests/Aspire.Hosting.DevTunnels.Tests/TestDevTunnelClient.cs (changed test)
→ 1 directly: Aspire.Hosting.DevTunnels.Tests

Job reasons

Job Triggered by
extension-e2e • src/Aspire.Hosting.DevTunnels/DevTunnelHealthCheck.cs, src/Aspire.Hosting.DevTunnels/DevTunnelResourceBuilderExtensions.cs
• affected project Aspire.Hosting.DevTunnels
typescript-api-compat affected project Aspire.Hosting.DevTunnels

Selection computed for commit 1f2130f.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@DamianEdwards
Damian Edwards (DamianEdwards) merged commit 0aced06 into release/13.5 Sep 2, 2026
676 of 679 checks passed
@DamianEdwards
Damian Edwards (DamianEdwards) deleted the backport/pr-19230-to-release/13.5 branch September 2, 2026 20:23
@github-actions github-actions Bot added this to the 13.5.x milestone Sep 2, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot removed this from the 13.5.x milestone Sep 2, 2026
@aspire-repo-bot

aspire-repo-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

✅ No documentation update needed.

Step 5 branch taken: excluded → base_branch_is_release, head_branch_is_backport, title_release_prefix, body_backport_marker

  • signals.json sets excluded: true with exclusion_reasons: base_branch_is_release, head_branch_is_backport, title_release_prefix, body_backport_marker.
  • Triggered signals: none (signal_count: 0).
  • Evidence: title is [release/13.5] Fix DevTunnel health check for auto-selected regions (release-prefixed), body starts with "Backport of Fix DevTunnel health check for auto-selected regions #19230 to release/13.5" (backport marker), and base ref is release/13.5.

This PR is a backport of #19230 to release/13.5. Per the workflow rules, backport PRs are out of scope for docs generation — documentation for the underlying change should be authored against the original forward PR (#19230) on the default branch, not duplicated here. No docs PR drafted.

@github-actions github-actions Bot mentioned this pull request Sep 3, 2026
Open
This was referenced Sep 15, 2026
Open
Open
Open
Open
Open
Merged
This was referenced Sep 16, 2026
Open
Merged
Open
Closed
Open
Open
Merged
Open
Closed
Open
Open
Open
Open
Open
Merged
Closed
Open
Open
Merged
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mitchdenny Mitch Denny (mitchdenny) mitchdenny approved these changes

Assignees

No one assigned

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mitchdenny @DamianEdwards